pulled in main
This commit is contained in:
@@ -101,12 +101,21 @@ impl RpcHandler {
|
||||
detected.iter().any(|d| d == &path),
|
||||
"{path} is not a detected mesh-radio candidate port"
|
||||
);
|
||||
let service = self.mesh_service.read().await;
|
||||
let probe = match service.as_ref() {
|
||||
Some(svc) => svc.probe_device(&path).await?,
|
||||
// No mesh service yet (radio never enabled) — probe directly.
|
||||
None => mesh::listener::probe_device(&path).await?,
|
||||
};
|
||||
// Only hold the mesh_service lock long enough for the quick
|
||||
// active-path guard check — NEVER across the actual probe, which
|
||||
// can take 15-60s across its internal collision retries. Confirmed
|
||||
// live 2026-07-23: holding this read lock for the full probe starved
|
||||
// a concurrent firmware-flash job's MeshService::stop() (which needs
|
||||
// the write lock) well past its own bounded timeout, surfacing as
|
||||
// "Mesh listener did not release the serial port" even though
|
||||
// stop() itself was fast.
|
||||
{
|
||||
let service = self.mesh_service.read().await;
|
||||
if let Some(svc) = service.as_ref() {
|
||||
svc.ensure_probe_allowed(&path).await?;
|
||||
}
|
||||
}
|
||||
let probe = mesh::listener::probe_device(&path).await?;
|
||||
Ok(serde_json::to_value(probe)?)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user