fix(setup): wizard navigation round-trips — back to Setup tab, goal-aware channels back button, configure launches the app

- "Back to Goals" now returns to Home's Setup tab (?tab=setup) instead of
  landing on the dashboard tab.
- The channels screen remembers when a setup wizard sent you there
  (?from=goal) — its back button reads "Back to Setup" and returns to the
  wizard; it also now uses the shared BackButton pill instead of a bare
  link.
- "Open & Configure" steps launch the actual app via the app launcher —
  iframe apps overlay on top of the wizard, tab-only apps (BTCPay,
  Nextcloud) open a tab, mobile uses the in-app browser — instead of
  routing to the app-details page.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

neode-ui/src/views/goals/__tests__/goalStepActions.test.ts

@@ -1,29 +1,37 @@
 import { describe, expect, it } from 'vitest'
 import { GOALS } from '@/data/goals'
-import { goalStepTargetPath } from '../goalStepActions'
+import { goalStepRouteOverride } from '../goalStepActions'
 import type { GoalStep } from '@/types/goals'
 
 describe('goalStepActions', () => {
-  it('routes app-backed steps to their app details page', () => {
-    expect(goalStepTargetPath(step({ id: 'configure-filebrowser', appId: 'filebrowser' }))).toBe('/dashboard/apps/filebrowser')
+  it('app-backed configure steps have no route override — they launch the app itself', () => {
+    expect(goalStepRouteOverride(step({ id: 'configure-filebrowser', appId: 'filebrowser' }))).toBeNull()
+    expect(goalStepRouteOverride(step({ id: 'configure-store', appId: 'btcpay-server' }))).toBeNull()
   })
 
   it('routes built-in identity and backup steps to their owning screens', () => {
-    expect(goalStepTargetPath(step({ id: 'setup-nostr' }))).toBe('/dashboard/web5')
-    expect(goalStepTargetPath(step({ id: 'export-identity' }))).toBe('/dashboard/web5/credentials')
-    expect(goalStepTargetPath(step({ id: 'create-passphrase' }))).toBe('/dashboard/settings')
+    expect(goalStepRouteOverride(step({ id: 'setup-nostr' }))).toBe('/dashboard/web5')
+    expect(goalStepRouteOverride(step({ id: 'export-identity' }))).toBe('/dashboard/web5/credentials')
+    expect(goalStepRouteOverride(step({ id: 'create-passphrase' }))).toBe('/dashboard/settings')
+  })
+
+  it('routes channel steps to the Lightning channels screen', () => {
+    expect(goalStepRouteOverride(step({ id: 'open-channel' }))).toBe('/dashboard/apps/lnd/channels')
+    expect(goalStepRouteOverride(step({ id: 'open-channels' }))).toBe('/dashboard/apps/lnd/channels')
+    expect(goalStepRouteOverride(step({ id: 'open-zeus-channel' }))).toBe('/dashboard/apps/lnd/channels')
   })
 
   it('keeps passive info steps without a target route', () => {
-    expect(goalStepTargetPath(step({ id: 'sync-setup' }))).toBeNull()
+    expect(goalStepRouteOverride(step({ id: 'sync-setup' }))).toBeNull()
   })
 
-  it('gives every configure step in the shipped goals a destination', () => {
+  it('gives every shipped configure step a destination — a route override or an app to launch', () => {
     const configureSteps = GOALS.flatMap((goal) => goal.steps.filter((candidate) => candidate.action === 'configure'))
 
-    expect(configureSteps.map((candidate) => [candidate.id, goalStepTargetPath(candidate)])).toEqual(
-      configureSteps.map((candidate) => [candidate.id, expect.any(String)]),
-    )
+    for (const candidate of configureSteps) {
+      const destination = goalStepRouteOverride(candidate) ?? candidate.appId ?? null
+      expect(destination, `configure step ${candidate.id} has no destination`).not.toBeNull()
+    }
   })
 })
 

neode-ui/src/views/goals/goalStepActions.ts

@@ -1,5 +1,6 @@
 import type { GoalStep } from '@/types/goals'
 
+// Steps that land on an internal screen rather than launching an app UI.
 const STEP_ROUTE_OVERRIDES: Record<string, string> = {
   'setup-nostr': '/dashboard/web5',
   'export-identity': '/dashboard/web5/credentials',
@@ -13,9 +14,11 @@ const STEP_ROUTE_OVERRIDES: Record<string, string> = {
   'open-zeus-channel': '/dashboard/apps/lnd/channels',
 }
 
-export function goalStepTargetPath(step: GoalStep): string | null {
-  const override = STEP_ROUTE_OVERRIDES[step.id]
-  if (override) return override
-  if (step.appId) return `/dashboard/apps/${step.appId}`
-  return null
+/**
+ * Internal route a step navigates to, or null when the step should launch its
+ * app instead (via the app launcher — iframe apps overlay on top, tab-only
+ * apps open a tab / the mobile in-app browser).
+ */
+export function goalStepRouteOverride(step: GoalStep): string | null {
+  return STEP_ROUTE_OVERRIDES[step.id] ?? null
 }