lfg2025/archy
1
0
Fork 0
Code Issues 24 Pull Requests 1 Actions Packages Projects Releases 64 Wiki Activity

docs: pin UIFIX-04/05/06 todos with 02-08 classification pointers

Browse Source
This commit is contained in:
archipelago 2026-07-30 23:26:30 -04:00
parent 834edd8c00
commit 91f17f5ab2
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.planning/todos/pending/2026-07-30-missing-loader-states-on-slow-opens.md
View File

@ -13,4 +13,4 @@ Dorian (2026-07-30): "some stuff doesn't have loader states when it's gonna take
## Solution
Inventory slow-open surfaces (02-08's PERF-AFTER timings + the flagged timing regressions are a starting list: Discover, Server, Web5, Fleet, AppDetails, OpenWrtGateway); add house-style skeletons/spinners where an open can exceed ~300ms, consistent with the phase 2 rule that cached revisits show no spinner (loaders only where genuinely uncached/slow, e.g. first visits and secondary screens). Tracked as UIFIX-06 (phase 1). Await 02-08's classification for pointers.
Inventory slow-open surfaces (02-08's PERF-AFTER timings + the flagged timing regressions are a starting list: Discover, Server, Web5, Fleet, AppDetails, OpenWrtGateway); add house-style skeletons/spinners where an open can exceed ~300ms, consistent with the phase 2 rule that cached revisits show no spinner. Clearest confirmed instance (02-08 classification, pre-existing since 2026-07-22): `Cloud.vue` `viewPaidItem()`'s `content.owned-get` call has a 60s timeout and zero loading indicator. `CloudFolder.vue`'s native file grid already has a skeleton (fine). Tracked as UIFIX-06 (phase 1).

2
.planning/todos/pending/2026-07-30-peer-files-pictures-open-in-tab-not-lightbox.md
View File

@ -13,4 +13,4 @@ Dorian (2026-07-30, on archi-dev-box; initially said "peer files", corrected to
## Solution
Route Paid Files image clicks through the existing lightbox component (find where other Cloud/media surfaces invoke it and reuse — likely the same lightbox used by My Files). Tracked as UIFIX-04 (phase 1). Await 02-08's classification report for exact file/line pointers.
Route Paid Files image clicks through the existing lightbox component. Classified by 02-08 (pre-existing, introduced f3393581 2026-07-22): `Cloud.vue`'s `viewPaidItem()` (~line 470) calls `window.open(...)` instead of routing into `MediaLightbox.vue`. Fix: invoke MediaLightbox the way My Files does. Tracked as UIFIX-04 (phase 1).

2
.planning/todos/pending/2026-07-30-pip-should-close-lightbox-with-fluid-animation.md
View File

@ -13,7 +13,7 @@ Dorian (2026-07-30), two reports:
1. Entering picture-in-picture on a video does not close the lightbox — it should close with a fluid on-brand animation as PiP begins.
2. "Picture in picture must survive tab changes or video buffering pauses, doesn't seem to, please fix." — PiP currently dies when switching main tabs and/or when the video pauses to buffer.
Suspect for the tab-change death: phase 2's KeepAlive lifecycle teardowns (02-04 moved intervals/listeners to onDeactivated — if any teardown pauses or resets media elements on deactivate, that kills PiP). Removing the video element from the DOM also ends PiP by browser design — the kept-alive instance should actually HELP here (element persists off-screen) if nothing pauses it. Buffering-pause death is likely separate close-on-pause logic in the lightbox/player. 02-08's classification report will pin the exact causes.
Classified by 02-08 (all pre-existing, NOT phase 2): `src/utils/pip.ts`'s `togglePip()` (introduced f72d4b92 2026-07-23) never touches `MediaLightbox.vue`'s visibility state; no `onDeactivated` teardown exists in Cloud/CloudFolder/MediaLightbox (phase 2 added none there); pre-phase-2 tab switches fully unmounted the view, so PiP tab-survival never existed. The `<video>` has zero pause/waiting/stalled listeners — buffering behavior is pure native. KeepAlive actually helps now: the element persists off-screen, so survival is achievable by not letting anything pause/unmount it.
## Solution