Pending peer request shows up again after being signed
Steps to Reproduce
Search for nodes:
Request a connection.
On the other node, refresh "Pending peer requests"
You should see the incoming request. Click approve and then click Poll Now. You will see the approved request plus a new pending one. Can be repeated
Expected Behavior
It should only show the approved request
Actual Behavior
Archipelago Version
1.7.56
Hardware
x86_64 (Intel/AMD)
Relevant Logs
No response
Screenshots
No response
### Description
Pending peer request shows up again after being signed
### Steps to Reproduce
Search for nodes:
Request a connection.
On the other node, refresh "Pending peer requests"
You should see the incoming request. Click approve and then click Poll Now. You will see the approved request plus a new pending one. Can be repeated
### Expected Behavior
It should only show the approved request
### Actual Behavior
### Archipelago Version
1.7.56
### Hardware
x86_64 (Intel/AMD)
### Relevant Logs
_No response_
### Screenshots
_No response_
Fixed: the inbound-request dedup now rejects re-syncs for peers that are already Pending OR Approved (core/archipelago/src/federation/pending.rs — insert_inbound), so approving + Poll Now no longer spawns a fresh pending row. Rejected is intentionally left out so a rejected peer can ask again. Added regression test test_approved_request_does_not_respawn_pending (passing). Closing.
Fixed: the inbound-request dedup now rejects re-syncs for peers that are already `Pending` OR `Approved` (`core/archipelago/src/federation/pending.rs` — `insert_inbound`), so approving + Poll Now no longer spawns a fresh pending row. `Rejected` is intentionally left out so a rejected peer can ask again. Added regression test `test_approved_request_does_not_respawn_pending` (passing). Closing.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Description
Pending peer request shows up again after being signed
Steps to Reproduce
Search for nodes:
Request a connection.
On the other node, refresh "Pending peer requests"
You should see the incoming request. Click approve and then click Poll Now. You will see the approved request plus a new pending one. Can be repeated
Expected Behavior
It should only show the approved request
Actual Behavior
Archipelago Version
1.7.56
Hardware
x86_64 (Intel/AMD)
Relevant Logs
No response
Screenshots
No response
[Bug]:to [Bug]: Strange peer request behaviourFixed: the inbound-request dedup now rejects re-syncs for peers that are already
PendingORApproved(core/archipelago/src/federation/pending.rs—insert_inbound), so approving + Poll Now no longer spawns a fresh pending row.Rejectedis intentionally left out so a rejected peer can ask again. Added regression testtest_approved_request_does_not_respawn_pending(passing). Closing.