[Bug]: Companion app asks if you want to install companion app #61

Closed
opened 2026-06-26 21:09:58 +00:00 by ssmithx · 2 comments
Collaborator

Description

When you install and connect to a server, archipelago asks you if you want to install the companion app...on the companion app.

Steps to Reproduce

Log into a new machine with the companion app
It should prompt you to install the companion app

Expected Behavior

It should not ask

Actual Behavior

It asks you to install the companion app

Archipelago Version

1.7.99-alpha

Hardware

x86_64 (Intel/AMD)

Relevant Logs

No response

Screenshots

No response

### Description When you install and connect to a server, archipelago asks you if you want to install the companion app...on the companion app. ### Steps to Reproduce Log into a new machine with the companion app It should prompt you to install the companion app ### Expected Behavior It should not ask ### Actual Behavior It asks you to install the companion app ### Archipelago Version 1.7.99-alpha ### Hardware x86_64 (Intel/AMD) ### Relevant Logs _No response_ ### Screenshots _No response_
Collaborator

The auto-popup is fixed: CompanionIntroOverlay checks for the companion's own JS bridge (window.ArchipelagoNative) and never auto-shows inside the companion app — the “install the companion app” prompt can’t appear there anymore. (Residual polish: the App Store companion banner is still shown to companion users; tracked with the companion-app work.)

The auto-popup is fixed: `CompanionIntroOverlay` checks for the companion's own JS bridge (`window.ArchipelagoNative`) and never auto-shows inside the companion app — the “install the companion app” prompt can’t appear there anymore. (Residual polish: the App Store companion banner is still shown to companion users; tracked with the companion-app work.)
chaum closed this issue 2026-08-30 13:44:49 +00:00
Owner

Residual from the 2026-08-30 handoff closed in companion/0.5.28 (web-side, no APK change): the two ungated paths — <CompanionBanner /> (Discover.vue) and openCompanionIntro() (useCompanionIntro.ts) — now gate on isCompanionApp(), and CompanionIntroOverlay's manual-open watcher refuses to open inside the app. The overlay's raw window.ArchipelagoNative check also moved to the canonical helper so detection lives in exactly one place. Vitest added (composables/__tests__/useCompanionIntro.test.ts); full suite green (1013 tests), type-check clean.

Residual from the 2026-08-30 handoff closed in `companion/0.5.28` (web-side, no APK change): the two ungated paths — `<CompanionBanner />` (`Discover.vue`) and `openCompanionIntro()` (`useCompanionIntro.ts`) — now gate on `isCompanionApp()`, and `CompanionIntroOverlay`'s manual-open watcher refuses to open inside the app. The overlay's raw `window.ArchipelagoNative` check also moved to the canonical helper so detection lives in exactly one place. Vitest added (`composables/__tests__/useCompanionIntro.test.ts`); full suite green (1013 tests), type-check clean.
Sign in to join this conversation.
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfg2025/archy#61