archipelagoandClaude Fable 5
24a34a373f
Recurring regression (reported again on .228, 2026-08-06): clicking a tx opened the tx1138.com consent modal even though the node runs Mempool. Root cause was never the preference — getAppState() reports 'not-installed' for an app whose container list simply has not been fetched yet, so a click that landed before the list arrived took the external path. Timing-dependent, hence 'fixed a thousand times'. - container store: flag + (shared in-flight promise) so 'not yet known' is distinguishable from 'not installed'. - openTx: awaits real data, and the local app wins whenever installed — including stopped/restarting, where the app session's own controls are the right landing place. Only a genuinely app-less node goes external. - 5 regression tests incl. the race itself; vue-tsc -b clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
87 lines
3.1 KiB
TypeScript
87 lines
3.1 KiB
TypeScript
// Regression suite for the recurring "tx link opens tx1138.com instead of
|
|
// the local Mempool app" bug (reported again on .228, 2026-08-06).
|
|
//
|
|
// The root cause was never the explorer preference — it was that
|
|
// `getAppState` reports `not-installed` for an app whose container list has
|
|
// not been fetched yet. A click that landed before the list arrived sent
|
|
// the user to a third-party explorer, telling that operator which
|
|
// transaction they cared about. These tests pin the fix: the decision waits
|
|
// for real data, and the local app wins whenever it exists.
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { setActivePinia, createPinia } from 'pinia'
|
|
|
|
const openSession = vi.fn()
|
|
vi.mock('@/stores/appLauncher', () => ({
|
|
useAppLauncherStore: () => ({ openSession }),
|
|
}))
|
|
|
|
let containerState: string
|
|
let fetched: boolean
|
|
const ensureFetched = vi.fn(async () => {
|
|
// Mirrors the real store: state only becomes knowable after the fetch.
|
|
fetched = true
|
|
})
|
|
vi.mock('@/stores/container', () => ({
|
|
useContainerStore: () => ({
|
|
ensureFetched,
|
|
getAppState: (_id: string) => (fetched ? containerState : 'not-installed'),
|
|
}),
|
|
}))
|
|
|
|
import { useTxExplorer, DEFAULT_TX_EXPLORER } from '../useTxExplorer'
|
|
|
|
const TX = 'a'.repeat(64)
|
|
|
|
describe('useTxExplorer.openTx', () => {
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
vi.clearAllMocks()
|
|
localStorage.clear()
|
|
fetched = false
|
|
containerState = 'running'
|
|
// Reset module-scope prefs/pending between tests.
|
|
const { setExplorer, cancelPending } = useTxExplorer()
|
|
setExplorer(DEFAULT_TX_EXPLORER, false)
|
|
cancelPending()
|
|
})
|
|
|
|
it('opens the local Mempool app when it is running', async () => {
|
|
const { openTx, pendingTx } = useTxExplorer()
|
|
await openTx(TX)
|
|
expect(openSession).toHaveBeenCalledWith('mempool', { path: `/tx/${TX}` })
|
|
expect(pendingTx.value).toBeNull()
|
|
})
|
|
|
|
it('waits for the container list rather than assuming not-installed (the race)', async () => {
|
|
const { openTx, pendingTx } = useTxExplorer()
|
|
// fetched=false at click time — the old synchronous check read
|
|
// 'not-installed' here and went external.
|
|
await openTx(TX)
|
|
expect(ensureFetched).toHaveBeenCalled()
|
|
expect(openSession).toHaveBeenCalledWith('mempool', { path: `/tx/${TX}` })
|
|
expect(pendingTx.value).toBeNull()
|
|
})
|
|
|
|
it('still prefers the local app when it is installed but stopped', async () => {
|
|
containerState = 'stopped'
|
|
const { openTx } = useTxExplorer()
|
|
await openTx(TX)
|
|
expect(openSession).toHaveBeenCalledWith('mempool', { path: `/tx/${TX}` })
|
|
})
|
|
|
|
it('prefers the local app mid-restart rather than leaking to a third party', async () => {
|
|
containerState = 'restarting'
|
|
const { openTx } = useTxExplorer()
|
|
await openTx(TX)
|
|
expect(openSession).toHaveBeenCalledWith('mempool', { path: `/tx/${TX}` })
|
|
})
|
|
|
|
it('asks for consent only when Mempool genuinely is not installed', async () => {
|
|
containerState = 'not-installed'
|
|
const { openTx, pendingTx } = useTxExplorer()
|
|
await openTx(TX)
|
|
expect(openSession).not.toHaveBeenCalled()
|
|
expect(pendingTx.value).toBe(TX)
|
|
})
|
|
})
|