With Bitcoin Core's wallet deleted, LND's PSBT round trip is the only external-signer path Archipelago has, and D-09's key-origin protection moves from Core descriptors (of which none remain) to the PSBT itself. Adds `psbt_key_origin_report(&str) -> Result<PsbtKeyOriginReport>` to lnd/wallet.rs, reporting `input_count`, `inputs_with_key_origin` and `all_inputs_have_key_origin`. An input counts as carrying key origin when either its `bip32_derivation` or `tap_key_origins` map is non-empty. A PSBT with zero inputs reports false rather than vacuous truth. Parsed with the already-present `bitcoin` and `base64` crates; no dependency added. `lnd.create-psbt` gains an additive `key_origin` object on its response and a `tracing::warn!` with the counts when key origin is missing, because that is the exact condition under which a hardware signer refuses the PSBT. Computed best-effort: a decode failure degrades to `null`, never to an error, so a user's send cannot fail because an inspection helper could not parse something. `handle_lnd_finalize_psbt` and `handle_lnd_create_raw_tx` (which deliberately auto-signs with LND's hot keys) are untouched. Three tests, with fixtures built programmatically from the `bitcoin` crate rather than pasted as opaque base64: with-derivations, without-derivations, and malformed-is-an-error-not-a-panic. KEY-03-SIGNING-POSTURE.md gains an honest per-step coverage map of the fund -> export -> sign offline -> import -> finalize -> broadcast round trip. Of six steps, only the new inspection has automated coverage; steps 1, 4, 5 and 6 have none, and there is no air-gap transport (no animated QR, no .psbt file exchange) — export/import is copy-paste of base64. Untested paths are named as untested. Records the verdict that decides whether any of this is an air gap: on a default node an external signer CANNOT meaningfully sign a PSBT from `lnd.create-psbt`, because LND holds the keys for every input it selects. Evidence: the PSBT is funded from LND's own wallet; `ensure_wallet_initialized` creates a full key-holding wallet via /v1/initwallet; the generated lnd.conf carries no `remotesigner.*` block; and a search of apps/, scripts/, core/archipelago/src and image-recipe/ for remotesigner/createwatchonly/ nochainbackend returns zero matches. No fleet node is provisioned watch-only. What ships is PSBT transport, not air-gapped custody — the gap is provisioning, not plumbing. Adds the standing honesty statement in its own subsection: Lightning channel, revocation and HTLC keys are NOT air-gappable at all. They must sign in real time to answer counterparty commitments; remote signing relocates them to a hardened host, it does not cool them. Also adds a status banner to PSBT-SIGNING-ARCHITECTURE.md recording that its Phase 1 was superseded by deletion rather than delivered, so §0's "single highest-value change" and §2.1's invariant now read against a code path that no longer exists. Banner only; §5.4's honesty table is byte-identical. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
24 KiB
KEY-03 — Signing posture after the Bitcoin Core wallet deletion
What this document is. The evidence-backed record of how Archipelago's Bitcoin signing posture stands after Phase 10 KEY-03. It supersedes, for the Bitcoin Core wallet specifically, the target state described in
docs/security/PSBT-SIGNING-ARCHITECTURE.md§8 Phase 1 — that phase planned to convert Core's wallet to watch-only; D-07b deleted the path instead.Governing decisions:
.planning/phases/10-key-material-hardening/10-CONTEXT.mdD-07b (final KEY-03 scope — delete, do not migrate) and D-07c (the deferred BDK cold vault, recorded so it is not lost with the code). D-07b supersedes D-07 and D-07a's conditional migration.Audit finding closed: F-13 (High) —
docs/security/ENTROPY-SEED-AUDIT-2026-07-31.md:604, remediation register R-04.
Bitcoin Core wallet path — deleted (D-07b)
What was deleted
| Symbol | Kind | Location before deletion |
|---|---|---|
handle_bitcoin_init_wallet_from_seed |
async fn |
core/archipelago/src/api/rpc/bitcoin.rs:161-295 |
"bitcoin.init-wallet-from-seed" |
JSON-RPC dispatch arm | core/archipelago/src/api/rpc/dispatcher.rs:122-124 |
The defect (F-13)
The handler loaded the encrypted seed, derived the BIP-84 account extended private key
(crate::seed::derive_bitcoin_xprv, bitcoin.rs:188), stringified it (:189), and imported
wpkh(xprv/0/*) and wpkh(xprv/1/*) (:230-231) into a Bitcoin Core descriptor wallet created
with disable_private_keys = false (:203) and an empty wallet passphrase (:205).
The result was a second copy of the node's spending key, persisted in Core's wallet.dat
inside the Bitcoin container's data volume, with no Argon2 passphrase — while the first copy sits
in the daemon's Argon2 + ChaCha20-Poly1305 envelope written 0600
(core/archipelago/src/seed.rs:238-269, :318-324). That duplication, into weaker protection,
was the entire finding.
Evidence that deletion was the right close (re-established for this task, not inherited)
The four D-07a evidence points, verified again against the tree before anything was removed:
1. No caller anywhere. Repo-wide search across core/, neode-ui/src, scripts/, web/,
apps/, tests/ and docs/, excluding core/target, node_modules and .git:
$ grep -rn 'bitcoin\.init-wallet-from-seed' core/ neode-ui/src scripts/ web/ apps/ tests/ docs/
core/archipelago/src/api/rpc/dispatcher.rs:122: "bitcoin.init-wallet-from-seed" => {
$ grep -rn 'handle_bitcoin_init_wallet_from_seed' core/ neode-ui/src scripts/ web/ apps/ tests/ docs/
core/archipelago/src/api/rpc/bitcoin.rs:161: pub(super) async fn handle_bitcoin_init_wallet_from_seed(
core/archipelago/src/api/rpc/dispatcher.rs:123: self.handle_bitcoin_init_wallet_from_seed(params).await
docs/UNIFIED-TASK-TRACKER.md:208: §8 Phase 1). `handle_bitcoin_init_wallet_from_seed` passes
docs/security/ENTROPY-SEED-AUDIT-2026-07-31.md:607:(`handle_bitcoin_init_wallet_from_seed`):
docs/security/PSBT-SIGNING-ARCHITECTURE.md:147: `handle_bitcoin_init_wallet_from_seed`, `core/archipelago/src/api/rpc/bitcoin.rs:161-294`).
Exactly one occurrence of the method name (its own dispatcher registration) and two of the symbol in code (its definition and the dispatcher call). The three remaining symbol hits are prose in documentation — the audit, the task tracker, and the PSBT architecture spec — not callers. No frontend, script, test or other Rust module invoked it.
2. LND is the wallet the product actually drives. Across all of neode-ui/src, every
bitcoin.* RPC call is read-only status: bitcoin.getinfo (14 call sites),
bitcoin.prune-status (3), bitcoin.onion (1). There are no bitcoin.* wallet operations.
The wallet UI (Web5Wallet.vue, SendBitcoinModal.vue) sends via lnd.sendcoins, estimates via
lnd.estimatefee, and reads balance via lnd.getinfo.
3. The wallet it creates never existed on the reference node. Verified live on
archi-dev-box, 2026-08-02, against the running bitcoin-knots container (read-only RPCs
only — see the census section for the exact commands and the standing ban on
listdescriptors true):
listwalletdir → { "wallets": [ "gatewayd-02004b91…", "gatewayd-03443c0c…", "" ] }
listwallets → [ "" ]
There is no wallet named archipelago — the handler's default wallet_name
(bitcoin.rs:170-173). It has never run on this node. getwalletinfo on the one loaded wallet
(the unnamed default) reports:
walletname: "" blank: true keypoolsize: 0
txcount: 0 balance: 0.00000000
descriptors: true private_keys_enabled: true
blank: true with keypoolsize: 0 and txcount: 0 is Bitcoin Core's own statement that no
key was ever imported into it and no transaction ever touched it. The two gatewayd-* entries
are Fedimint gateway wallets, unrelated to the BIP-84 path. The wallet.dat at the datadir root
is Core's own legacy default-wallet location, not this handler's output.
This is one node. archi-dev-box is verified; the rest of the fleet is UNVERIFIED pending the census below.
Supporting history evidence: git log -S "init-wallet-from-seed" scoped to
core/archipelago/src/api/rpc/dispatcher.rs and neode-ui/src returns exactly one commit —
19dcfd4f feat: BIP-39 master seed for unified key derivation, the commit that added it. No
frontend wrapper was ever written: it was built and never wired up.
4. It was never remotely reachable. The endpoint is absent from UNAUTHENTICATED_METHODS
(core/archipelago/src/api/rpc/middleware.rs:5-40) — so it required an authenticated session —
and it additionally re-verified the user's password before touching the seed
(self.auth_manager.verify_password(password), bitcoin.rs:176-179). F-13 was therefore
key-at-rest duplication, not an exposed endpoint. That is why it was rated High rather than
Critical, and why deleting it is a hardening measure rather than an incident response.
What was not wrong with it
Worth stating so the record is fair, and so the next reader does not mistake the lesson. The
in-memory handling of the xprv string was careful: it was zeroized on the error path
(bitcoin.rs:222) and on the success path (:284), matching the standard set elsewhere in
seed.rs. The wallet type was also correct — createwallet already passed descriptors = true
(:207), which is the right foundation.
The defect was which key went into the wallet, not how the key was held in memory or what kind
of wallet it was. A watch-only rewrite (xpub + [fingerprint/derivation] key origin) would
have been a legitimate fix. Deletion was chosen over rewrite because the endpoint had no caller,
no consumer, and no product role: rewriting it would have produced a correct implementation of
something nothing uses, and left a wallet-creating code path to be maintained and re-audited
forever.
How F-13 is closed
By removal, not by conversion to watch-only. After this change there is no code path in the daemon that writes the BIP-84 account private key into Bitcoin Core. The only on-node copy of that key is the daemon's Argon2 + ChaCha20-Poly1305 envelope.
No migration was performed and none is planned. D-07's parity-proof migration and its one-way checkpoint are withdrawn (D-07b) — there is no wallet to migrate. If a fleet node is ever found holding a descriptor wallet this handler created, that is a finding to surface and stop on, not a trigger to auto-migrate: it would mean the endpoint was invoked by hand and that node's spending key is duplicated in Core, which deserves a human decision rather than an automated rewrite of a wallet that may hold funds.
This deletion removes code, not wallets
Stated explicitly so nobody reading the change later has to wonder whether it was destructive:
Nothing on disk is touched. No
wallet.datis modified, unloaded or removed. No funds move. No LND state, secret, descriptor or seed is altered. The change removes a Rust function and amatcharm — the path by which a private key could be imported into Bitcoin Core — and nothing else.
This holds even on a hypothetical node where the endpoint had been invoked by hand: deleting the handler destroys nothing there either. It closes the door; it does not clean the room. Cleaning up such a wallet, if one is ever found, is a separate human decision (see the census below), and CLAUDE.md's "migrations never destroy data" invariant is not engaged by this change because there is no migration.
What deletion does to D-08 and D-09
Neither decision lapses; both are satisfied by a different mechanism.
- D-08 asked that the spending key exist in exactly one place, with an opt-in air-gapped path. Deleting the Core import achieves the first half outright. The opt-in path is LND's existing PSBT round trip, not a Core watch-only wallet — see the next section, including the recorded verdict on how far that actually goes today.
- D-09 required a
[fingerprint/derivation]key origin on emitted descriptors so a hardware signer can locate its key. With Core's descriptors deleted there are no Archipelago-emitted descriptors left to annotate, so D-09's actual protection moves to the PSBT itself. That is whylnd.create-psbtnow inspects and reports the key-origin data its PSBT carries (psbt_key_origin_report,core/archipelago/src/api/rpc/lnd/wallet.rs).
derive_bitcoin_xprv is retained deliberately (D-07c)
crate::seed::derive_bitcoin_xprv (core/archipelago/src/seed.rs:231) lost its only non-test
caller and was kept, marked #[allow(dead_code)] with the reason in its doc comment. It is
covered by existing tests (seed.rs:601-602, :856) and it is the derivation D-07c's deferred
BDK cold vault — a descriptor wallet in the daemon using the node's own ElectrumX app
(apps/electrumx, electrs_status.rs) as chain source — will need.
D-07c was considered and deliberately deferred out of Phase 10 (it needs its own phase: a new
dependency and a new UI surface). It is recorded here, and in the function's doc comment, so the
option is not quietly lost along with the code that was deleted. The alternative shape — LND
watch-only via importaccount plus remote signing — was considered and rejected for coupling
cold storage to LND's upgrade path.
LND PSBT round trip — what is covered
With Core's wallet deleted, LND is the only wallet Archipelago has, and its PSBT round trip is the only external-signer path that exists. This section records what that path actually consists of, what is tested, and — the question that decides whether any of it is an air gap — whether an externally-held signer can sign a default node's PSBT at all.
Per-step coverage map
Round trip: fund → export → sign offline → import → finalize → broadcast.
| # | Step | Where it lives | file:line |
Automated test coverage |
|---|---|---|---|---|
| 1 | Fund — build a funded PSBT via LND WalletKit /v2/wallet/psbt/fund |
lnd.create-psbt handler |
core/archipelago/src/api/rpc/lnd/wallet.rs:605; dispatch arm api/rpc/dispatcher.rs:136 |
Untested. No LND mock exists; the handler's request/response handling is exercised only by hand. |
| 1a | Inspect — report BIP-32 key origin on the funded PSBT | psbt_key_origin_report + wiring |
lnd/wallet.rs:1186 (fn), :1169 (struct), :705 (call site), :737 (response field) |
Tested. 3 unit tests, below. |
| 2 | Export — hand the base64 PSBT to the user | UI renders psbt_base64 for copy |
neode-ui/src/api/rpc-client.ts:407-423; neode-ui/src/views/web5/Web5SendReceiveModals.vue:308 |
Partial. neode-ui/src/api/__tests__/rpc-client.test.ts:319-323 asserts only that the client calls the method lnd.create-psbt; it does not test the payload or the rendering. |
| 3 | Sign offline — external signer produces a signed PSBT | Not in this repo. No first-party signer ships today. | — | N/A |
| 4 | Import — user pastes the signed PSBT back | textarea → signedPsbtInput |
Web5SendReceiveModals.vue:102, :419-424 |
Untested. |
| 5 | Finalize — /v2/wallet/psbt/finalize |
lnd.finalize-psbt handler |
lnd/wallet.rs:743; dispatch arm dispatcher.rs:137 |
Untested. |
| 6 | Broadcast — /v2/wallet/tx, in the same handler |
handle_lnd_finalize_psbt tail |
lnd/wallet.rs:795 |
Untested. |
| — | Rate limiting — both endpoints at 5 calls / 300s | RateLimiter defaults |
core/archipelago/src/rate_limit.rs:68-69 |
Untested for these two methods specifically. |
Stated plainly, because an untested path must not be described as verified: of the six steps, one (the key-origin inspection added by this plan) has automated coverage in the Rust crate. Steps 1, 4, 5 and 6 have none — no test exercises the LND REST calls, the finalize handler, or the broadcast. Step 2's only test asserts a method name. No end-to-end test of the round trip exists, and none of it has been verified against a real hardware signer.
There is also no air-gap transport: no animated QR encode/decode, no .psbt file
download/upload. Export and import are copy-paste of base64 in a textarea. The BC-UR v2 / BBQr
design in PSBT-SIGNING-ARCHITECTURE.md §4 is unimplemented.
New tests added by this plan
In core/archipelago/src/api/rpc/lnd/wallet.rs's mod tests, with fixtures built
programmatically from the bitcoin crate rather than pasted as opaque base64:
| Test | Asserts |
|---|---|
psbt_without_derivations_reports_no_key_origin |
A one-input unsigned PSBT with no bip32_derivation reports inputs_with_key_origin: 0 and all_inputs_have_key_origin: false. |
psbt_with_derivations_reports_key_origin |
The same PSBT with a (Fingerprint, DerivationPath) inserted on input 0 reports 1/1 and true. |
malformed_psbt_is_an_error_not_a_panic |
Non-base64, truncated-PSBT and empty inputs all return Err, never panic. |
running 3 tests
test api::rpc::lnd::wallet::tests::psbt_with_derivations_reports_key_origin ... ok
test api::rpc::lnd::wallet::tests::psbt_without_derivations_reports_no_key_origin ... ok
test api::rpc::lnd::wallet::tests::malformed_psbt_is_an_error_not_a_panic ... ok
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 1014 filtered out
lnd.create-psbt now returns an additive key_origin field:
"key_origin": { "input_count": 1, "inputs_with_key_origin": 0, "all_inputs_have_key_origin": false }
It is computed best-effort: a decode failure degrades to null and logs a warning, never to
an error — a user's send must not fail because an inspection helper could not parse something.
When all_inputs_have_key_origin is false the handler emits a tracing::warn! with the counts,
because that is the exact condition under which a hardware signer refuses the PSBT. Existing
response fields are unchanged; handle_lnd_finalize_psbt and handle_lnd_create_raw_tx (the
sibling that deliberately auto-signs with LND's hot keys) were not touched.
Can an external signer actually sign a default node's PSBT? — No, not today
This is the question that separates "we have PSBT plumbing" from "we have air-gapped custody", and the two must not be allowed to blur.
Verdict: on a default Archipelago node, an externally-held signer cannot meaningfully sign a
PSBT produced by lnd.create-psbt. The evidence:
- The PSBT is funded from LND's own wallet.
lnd.create-psbtPOSTs to LND's WalletKit/v2/wallet/psbt/fund(lnd/wallet.rs:672), which selects UTXOs belonging to LND's wallet. The keys for those inputs are the keys LND holds. - LND's wallet on every node is a full key-holding wallet, created locally.
container::lnd::ensure_wallet_initialized(core/archipelago/src/container/lnd.rs:86) callsinit_wallet_via_rest, which POSTs/v1/initwalletwith acipher_seed_mnemonic(container/lnd.rs:504-516) and persists the aezeed backup (:523-525). That is a normal wallet with private keys, not a watch-only one. - No node's
lnd.confcarries a remote-signing block. The config Archipelago generates (container/lnd.rs:64-79) containsbitcoin.node=bitcoindand the bitcoind RPC settings, and noremotesigner.*keys at all. - Nothing in the repo provisions watch-only LND. A search of
apps/,scripts/,core/archipelago/srcandimage-recipe/forremotesigner,createwatchonlyandnochainbackendreturns zero matches. There is no code path, script or manifest that sets any node up this way.
An external signer could only sign these inputs if LND were first provisioned watch-only
against that signer — remotesigner.* on the node plus lncli createwatchonly from the
signer's exported accounts, with the level-3 accounts and the p2tr import step described in
PSBT-SIGNING-ARCHITECTURE.md §5.1-5.2. No fleet node is so provisioned.
What therefore ships today is the PSBT transport, not air-gapped custody. The round trip is
real and rate-limited, and it is genuinely useful for signing a PSBT whose inputs belong to some
other wallet — but on a default node the signer that holds the input keys is LND itself, so
routing the PSBT out to an external device and back adds a step without moving custody anywhere.
The gap between here and D-08's opt-in air-gapped path is provisioning, not plumbing, and
that provisioning is out of scope for Phase 10 (it is PSBT-SIGNING-ARCHITECTURE.md §8 Phase 6).
Nothing in the UI currently claims otherwise, and nothing added by this plan does either. If copy is ever written for this flow, it must not describe it as cold storage on the strength of the PSBT round trip alone.
Lightning channel, revocation and HTLC keys are not air-gappable — at all
This is a standing constraint, not a caveat, and it survives every change in this document.
A Lightning node's channel, revocation and HTLC keys must sign in real time to answer counterparty commitments. They cannot be air-gapped. A routing node cannot tolerate a human-in-the-loop signing step: a delayed response to a commitment update risks a force-close, and a missing revocation risks loss. LND remote signing relocates these keys to a hardened host — it does not cool them. There is no configuration, present or future, in which a live Lightning node's channel keys are cold.
This is the same limit stated in PSBT-SIGNING-ARCHITECTURE.md §5.1 ("Air-gap channel /
revocation / HTLC keys — No") and §5.4, whose honesty table remains correct and unmodified.
The consequence for user-facing copy, quoted from §5.4 and repeated here so it cannot be lost:
A Lightning routing node's channel keys are necessarily hot. Remote signing moves them to a hardened machine; it does not make them cold. Only your on-chain balance can be genuinely protected by an offline signer.
No wording in this document, or in any document this phase touches, may imply that Lightning funds can be held cold. A user who believes their Lightning balance is cold will keep more in it than they otherwise would, which is exactly the miscalibration that turns an incident into a loss.
Fleet census — Core descriptor wallets
Status: INCOMPLETE — one node verified, fleet pending. This section answers one question per
node: does this node hold a Bitcoin Core descriptor wallet that
handle_bitcoin_init_wallet_from_seed created, and does it hold private keys? It is recorded
per node rather than assumed, because deletion closes the door but does not tell us whether
anyone walked through it before.
Hard constraint on every command in this census
Never run
listdescriptors true. Thetrueargument makes Bitcoin Core return the descriptors including private keys, which would print an xprv to a terminal and into a transcript — creating the exact exposure this census exists to measure.listwalletdir,listwallets,getwalletinfoandlistdescriptorswith no second argument answer the question completely.If any output unexpectedly contains a string beginning
xprv, stop immediately, do not paste it, and report only that it occurred.
Commands (re-runnable by an auditor)
Per node, against the Bitcoin Core / Knots container:
# 0. Does the handler's wallets directory exist at all? An absent directory is
# itself a complete answer for that node — paste the output as-is.
ls -la /var/lib/archipelago/bitcoin/wallets/ 2>&1
# bitcoin-cli is NOT on $PATH inside the container. On archi-dev-box (Knots
# 29.3) it lives at:
# /opt/bitcoin-29.3.knots20260210/bin/bitcoin-cli
# The RPC user is `archipelago`; the password is read from
# /var/lib/archipelago/secrets/bitcoin-rpc-password
# — reference that path, never the value, and prefer -stdinrpcpass so the
# password never appears in a process list or shell history.
# 1. Every wallet on disk, loaded or not.
bitcoin-cli -rpcuser=archipelago -stdinrpcpass listwalletdir
# 2. Currently loaded wallets.
bitcoin-cli -rpcuser=archipelago -stdinrpcpass listwallets
# 3. Per wallet returned: record walletname, private_keys_enabled, descriptors,
# blank, keypoolsize, txcount, balance.
bitcoin-cli -rpcuser=archipelago -stdinrpcpass -rpcwallet=<name> getwalletinfo
# 4. ONLY for a wallet with private_keys_enabled: true — NOTE: no second argument.
# Record descriptor prefixes (`wpkh(...`) only, never a full key string.
bitcoin-cli -rpcuser=archipelago -stdinrpcpass -rpcwallet=<name> listdescriptors
# 5. Which Bitcoin app and version.
bitcoin-cli -rpcuser=archipelago -stdinrpcpass getnetworkinfo | head
Results
| Node | App / version | wallets_dir_present |
listwallets |
archipelago wallet? |
Private-key-bearing wallet? | Verdict |
|---|---|---|---|---|---|---|
| archi-dev-box | Bitcoin Knots 29.3 (bitcoin-knots container) |
— (listwalletdir used instead) |
[ "" ] |
No | The unnamed default wallet reports private_keys_enabled: true, but also blank: true, keypoolsize: 0, txcount: 0, balance: 0 — Core's own statement that no key was ever imported and no transaction ever touched it. It is not this handler's output. |
CLEAR — verified 2026-08-02 |
.228 (shorty-s, resilience node) |
— | — | — | — | — | UNCHECKED |
.198 (OptiPlex) |
— | — | — | — | — | UNCHECKED |
.116 (thinkpad / dev node) |
— | — | — | — | — | UNCHECKED |
x250-dev |
— | — | — | — | — | UNCHECKED |
| framework-pt | — | — | — | — | — | UNCHECKED |
listwalletdir on archi-dev-box also returned two gatewayd-02004b91… / gatewayd-03443c0c…
wallets. These are Fedimint gateway wallets, unrelated to the BIP-84 path and out of scope
for this finding.
Standing rule if a wallet is found
If any node reports a wallet named archipelago (or any descriptor wallet with
private_keys_enabled: true that this handler plausibly created), that is a finding:
- Stop. Record it here with the node label and wallet name.
- Raise it as a blocker. KEY-03 does not close until a human decides what to do about it.
- Do not migrate, unload, rescan or modify it. D-07b withdrew the migration deliberately. Rewriting a wallet that might hold funds is exactly the kind of decision that belongs to a human, and CLAUDE.md's "migrations never destroy data" invariant applies the moment anyone touches it.
Such a wallet would mean the endpoint was invoked manually before this plan deleted it, and that node's spending key is duplicated in Core outside the Argon2 envelope.