CI (.github/workflows/ci.yml) already runs
`cargo clippy --all-targets --all-features -- -D warnings`, but
archipelago-openwrt emitted 4 warnings on a clean checkout, so the gate
was red by default and enforced nothing. Fixed each lint at the source;
no #[allow] added.
- clippy::cmp_owned (wan.rs:146) — dropped the .to_string() that built an
owned String purely to compare against "1"; &str == &str compares the
same content.
- clippy::unnecessary_sort_by (wifi_scan.rs:75, :177) — replaced
sort_by(|a, b| b.signal.cmp(&a.signal)) with
sort_by_key(|n| std::cmp::Reverse(n.signal)). Both are stable descending
sorts on signal, so tie order is unchanged. Deliberately NOT -n.signal,
which would misorder i32::MIN.
- clippy::trim_split_whitespace (wifi_scan.rs:156) — removed the .trim()
before .split_whitespace(); the latter already skips leading/trailing
whitespace and never yields empty items, so parsing is unchanged.
All three are semantics-preserving rewrites: no change to comparison
results, sort ordering, or channel parsing.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
