Files
archy/neode-ui/e2e/perf/surface-perf.spec.ts
T
archipelagoandClaude Opus 5 b2c7592840
Demo images / Build & push demo images (push) Failing after 2m16s
security: parameterize node addresses; drop dead APP_URLS config
Keeps the dev and test tooling an outside contributor would want, and takes
our node addresses out of it.

Scripts that silently defaulted to one of our nodes now require an explicit
host and exit 2 without one: smoke-test.sh, trust-archipelago-cert.sh,
dev-container-test.sh (which also derives its RPC and health URLs from the
SSH target instead of a second hardcoded copy), and image-recipe/dev-branding.sh.
A default that points at a machine the user does not own is worse than no
default: it fails confusingly, or reaches a stranger's device.

Usage examples, mock data and test fixtures move to the RFC 5737
documentation range (192.0.2.0/24). CGNAT test values stay inside
100.64.0.0/10 so the range-check semantics they exercise still hold, and
192.168.1.0/.1/.254 are left alone — those are gateway logic and UI
placeholders, not our addresses.

Playwright and the perf spec defaulted their baseURL to one of our nodes;
they now default to localhost:8100, the local dev server.

Removed neode-ui APP_URLS entirely. It is dead code — exported, never
imported — and it pinned fedimint's *prod* launch URL to 192.168.1.228:8175.
Had anything consumed it, every user's node would have tried to reach an
address that on their LAN is either nothing or someone else's machine.
Deleting beats sanitizing dead config.

Verified: frontend 868/868 vitest across 108 files; archipelago-container
75/75; mesh tests 9/9; audit-secrets 5/5. Zero node addresses and zero node
names remain in tracked files.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-07 10:53:25 -04:00

106 lines
4.2 KiB
TypeScript

// Re-runnable surface-perf harness (02-01-PLAN.md Task 1). Logs in using the
// exact flow from app-launch.spec.ts, walks every SURFACES row via
// measureSurface(), and writes the full result array + a run header to
// ARCHY_PERF_OUT (defaulting to e2e/test-results/surface-perf.json).
//
// Redaction is structural, not a cleanup pass: measure.ts's RpcTracker only
// ever records method name + timing (T-02-06) — request/response bodies,
// page text and screenshots are never captured into the artifact.
import { execSync } from 'node:child_process'
import { mkdirSync, writeFileSync } from 'node:fs'
import { dirname, resolve } from 'node:path'
import { expect, test, type Page } from '@playwright/test'
import { measureSurface, type SurfaceMeasurement } from './measure'
import { SURFACES } from './surfaces'
const PASSWORD = process.env.ARCHY_PASSWORD ?? 'password123'
const RUNS = process.env.ARCHY_PERF_RUNS ? Number(process.env.ARCHY_PERF_RUNS) : 3
const OUT_PATH = resolve(process.cwd(), process.env.ARCHY_PERF_OUT ?? 'e2e/test-results/surface-perf.json')
async function login(page: Page): Promise<void> {
// Mirrors e2e/app-launch.spec.ts's login() verbatim — do not invent a
// second auth path.
await page.goto('/login', { waitUntil: 'domcontentloaded' })
await page.evaluate(() => {
localStorage.setItem('neode_intro_seen', '1')
localStorage.setItem('neode_onboarding_complete', '1')
})
await page.goto('/login', { waitUntil: 'networkidle' })
const passwordInput = page.locator('input[type="password"]').first()
await passwordInput.waitFor({ timeout: 15_000 })
await passwordInput.fill(PASSWORD)
await page
.locator('button:has-text("Login"), button:has-text("Unlock"), button:has-text("Continue"), button[type="submit"]')
.first()
.click()
await page.waitForURL('**/dashboard**', { timeout: 20_000 })
}
function currentCommit(): string {
try {
// `__dirname` is unavailable under this package's `"type": "module"` ESM
// runtime (Playwright's own transform swallows the ReferenceError into
// the catch below, silently yielding 'unknown') — use `process.cwd()`
// instead, which Playwright always sets to the project root it was
// invoked from.
return execSync('git rev-parse --short HEAD', { cwd: process.cwd() }).toString().trim()
} catch {
return 'unknown'
}
}
test('surface-perf: measure every D-09 surface and write the baseline artifact', async ({ page, baseURL }) => {
test.setTimeout(20 * 60 * 1000) // 15 surfaces x 3 runs x network round-trips can run long on a real node
await login(page)
const results: SurfaceMeasurement[] = []
const skipped: string[] = []
for (const surface of SURFACES) {
try {
const measurement = await measureSurface(page, surface, { runs: RUNS })
results.push(measurement)
if (measurement.error) skipped.push(`${surface.id}: ${measurement.error}`)
} catch (err) {
// A surface that throws outside measureSurface's own per-run try/catch
// (e.g. login state got corrupted) is still recorded, never dropped —
// an unmeasured surface must never silently disappear from the array.
results.push({
id: surface.id,
label: surface.label,
path: surface.path,
kind: surface.kind,
runs: RUNS,
samples: [],
firstVisitMs: null,
revisitMs: null,
firstVisitRpcCount: null,
revisitRpcCount: null,
revisitRpcCalls: [],
maxConcurrentRpc: null,
rpcWallClockMs: null,
remounted: null,
error: err instanceof Error ? err.message : String(err),
})
skipped.push(`${surface.id}: ${err instanceof Error ? err.message : String(err)}`)
}
}
const header = {
baseUrl: baseURL ?? process.env.ARCHY_BASE_URL ?? 'http://localhost:8100',
takenAt: new Date().toISOString(),
commit: currentCommit(),
runs: RUNS,
notes: skipped.length > 0 ? `Skipped/errored surfaces: ${skipped.join('; ')}` : 'All surfaces measured cleanly.',
}
const artifact = { ...header, results }
mkdirSync(dirname(OUT_PATH), { recursive: true })
writeFileSync(OUT_PATH, JSON.stringify(artifact, null, 2))
expect(results.length).toBe(SURFACES.length)
})